feat(auth): add logging support #11079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
codyoss
commented
Nov 2, 2024
•
codyoss
commented
- add logging to all outgoing requests
- accept a logger from public constructors
- left a TODO to cleanup in a followup metadata package PR
codyoss
added
the
do not merge
|
Requires googleapis/gax-go#380 |
codyoss
force-pushed
the
sloglogger-support
branch
2 times, most recently
from
a496957 to
ff21fde
Compare
- add logging to all outgoing requests - accpect a logger from public constructors
codyoss
force-pushed
the
sloglogger-support
branch
from
ff21fde to
1333764
Compare
codyoss
removed
the
do not merge
quartzmo
reviewed
Dec 11, 2024
quartzmo
requested changes
Dec 11, 2024
codyoss
force-pushed
the
sloglogger-support
branch
from
3ebb056 to
aa974d8
Compare
codyoss
added
the
automerge
quartzmo
approved these changes
Dec 12, 2024
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.