Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add support for providing custom certificate URL #11006

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat(auth): add support for providing custom certificate URL #11006

merged 4 commits into from
Nov 25, 2024
+127 −71

Conversation

idhame
Copy link
Contributor

@idhame idhame commented Oct 18, 2024

feat(auth): add support for providing custom certificate URL

address #11005

@idhame idhame requested a review from a team as a code owner October 18, 2024 07:47
@idhame idhame mentioned this pull request Nov 10, 2024
Closed
@quartzmo
Copy link
Member

@idhame I'm sorry for the long delay for this review. We have been busy, but nonetheless your contribution is very much appreciated! Great job on the code, docs and tests!

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2024
@quartzmo
Copy link
Member

@idhame Can you correct this minor vet error, thanks!

Error: auth/credentials/idtoken/validate_test.go:187:3: struct field certsUrl should be certsURL

@idhame
Copy link
Contributor Author

idhame commented Nov 25, 2024

thanks @quartzmo ! I've pushed the fix on vet error as well.

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2024
@quartzmo quartzmo merged commit ebf3657 into googleapis:main Nov 25, 2024
8 checks passed
@quartzmo
Copy link
Member

Thank you! 🎉

Note that this change won't be released until on or after 2024-12-04, due to a code freeze for US holidays.

@release-please release-please bot mentioned this pull request Nov 25, 2024
Merged
quartzmo added a commit that referenced this pull request Dec 3, 2024
@quartzmo
fix(auth): ensure endpoints are present in Validator (#11209)
106cd53 
refs: #11006
fixes: #11190
fixes: #11189
fixes: #11188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idhame @quartzmo @kokoro-team