feat(storage): GA gRPC client #10859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frankyn
commented
Sep 12, 2024
•
frankyn
commented
- Pending zero-copy improvements from @tritone
product-auto-label
bot
added
the
api: storage
frankyn
changed the title
tritone
reviewed
Sep 13, 2024
storage/doc.go
Outdated
| allowlist to access this API. The Go Storage gRPC library is not yet generally | ||
| available, so it may be subject to breaking changes. | ||
| This package includes support for the Cloud Storage gRPC API. The | ||
| implementation uses gRPC rather than the current |
storage/doc.go
Outdated
| This package includes support for the Cloud Storage gRPC API. The | ||
| implementation uses gRPC rather than the current | ||
| JSON & XML APIs to make requests to Cloud Storage. | ||
| The Go Storage gRPC library is generally available. |
storage/doc.go
Outdated
| warn that Direct Google Access could not be initialized. Direct Google Access | ||
| is not required to access the gRPC API. | ||
| Using the gRPC API inside GCP with a bucket in the same region can allow direct | ||
| connectivity (enabling requests to skip Google Front Ends (GFEs) and reducing |
There was a problem hiding this comment.
Google Front Ends is another term without public docs, I would revert to the original wording here and just add the link for the (new?) DP docs. No need to duplicate more information here.
frankyn
added
status: blocked
codyoss
reviewed
Sep 13, 2024
|
Thanks @codyoss updated PR name to |
tritone
removed
status: blocked
tritone
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.