Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): adds X509 workload certificate provider #10233

Merged
merged 13 commits into from
May 28, 2024

Conversation

aeitzman
Copy link
Contributor

See go/x509-workload-auth-library-design and go/guac-cba-x509-federation-golang.

Adds support for the new certificate provider type and unit tests, but does not add it to the default certificate provider logic yet.

@aeitzman aeitzman requested a review from a team as a code owner May 20, 2024 16:48
@codyoss codyoss changed the title feat: adds X509 workload certificate provider feat(auth): adds X509 workload certificate provider May 21, 2024
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just nit, otherwise LGTM

auth/internal/transport/cert/testdata/workload_cert.pem Outdated Show resolved Hide resolved
auth/internal/transport/cert/testdata/workload_key.pem Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
auth/internal/transport/cert/workload_cert.go Outdated Show resolved Hide resolved
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label May 28, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 17a9db7 into googleapis:main May 28, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants