-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): adds X509 workload certificate provider #10233
Merged
gcf-merge-on-green
merged 13 commits into
googleapis:main
from
aeitzman:workload-provider
May 28, 2024
Merged
feat(auth): adds X509 workload certificate provider #10233
gcf-merge-on-green
merged 13 commits into
googleapis:main
from
aeitzman:workload-provider
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
changed the title
feat: adds X509 workload certificate provider
feat(auth): adds X509 workload certificate provider
May 21, 2024
lsirac
approved these changes
May 22, 2024
codyoss
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly just nit, otherwise LGTM
codyoss
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
May 28, 2024
codyoss
approved these changes
May 28, 2024
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go/x509-workload-auth-library-design and go/guac-cba-x509-federation-golang.
Adds support for the new certificate provider type and unit tests, but does not add it to the default certificate provider logic yet.