From fea65381ac1b7662cc4d459f317ab328e07a02ae Mon Sep 17 00:00:00 2001 From: rahul yadav Date: Mon, 28 Oct 2024 15:23:17 +0530 Subject: [PATCH] fix tests --- spanner/read_test.go | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/spanner/read_test.go b/spanner/read_test.go index 3e0410ba3962..464ee9f46130 100644 --- a/spanner/read_test.go +++ b/spanner/read_test.go @@ -20,6 +20,7 @@ import ( "context" "errors" "fmt" + "go.opentelemetry.io/otel/metric/noop" "sync" "sync/atomic" "testing" @@ -882,6 +883,10 @@ func TestRsdNonblockingStates(t *testing.T) { } return } + mt.currOp.incrementAttemptCount() + mt.currOp.currAttempt = &attemptTracer{ + startTime: time.Now(), + } // Receive next decoded item. if r.next(&mt) { rs = append(rs, r.get()) @@ -1146,6 +1151,10 @@ func TestRsdBlockingStates(t *testing.T) { var rs []*sppb.PartialResultSet rowsFetched := make(chan int) go func() { + mt.currOp.incrementAttemptCount() + mt.currOp.currAttempt = &attemptTracer{ + startTime: time.Now(), + } for { if !r.next(&mt) { // Note that r.Next also exits on context cancel/timeout. @@ -1769,8 +1778,12 @@ func TestIteratorStopEarly(t *testing.T) { } func TestIteratorWithError(t *testing.T) { + metricsTracerFactory, err := newBuiltinMetricsTracerFactory(context.Background(), "projects/my-project/instances/my-instance/databases/my-database", noop.NewMeterProvider()) + if err != nil { + t.Fatalf("failed to create metrics tracer factory: %v", err) + } injected := errors.New("Failed iterator") - iter := RowIterator{err: injected} + iter := RowIterator{meterTracerFactory: metricsTracerFactory, err: injected} defer iter.Stop() if _, err := iter.Next(); err != injected { t.Fatalf("Expected error: %v, got %v", injected, err)