From 19f01c3c48ed1272c8fc0af9e5f69646cb662808 Mon Sep 17 00:00:00 2001 From: Frank Natividad Date: Thu, 14 Nov 2024 21:53:57 -0800 Subject: [PATCH] feat(storage): allow non default service account (#11137) * test(storage): re-enable DetectDirectConnectivity integration test * feat(storage): allow non default service account --- storage/grpc_client.go | 5 ++++- storage/integration_test.go | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/storage/grpc_client.go b/storage/grpc_client.go index 40789270540e..937360a4afd8 100644 --- a/storage/grpc_client.go +++ b/storage/grpc_client.go @@ -101,7 +101,10 @@ func defaultGRPCOptions() []option.ClientOption { ) } else { // Only enable DirectPath when the emulator is not being targeted. - defaults = append(defaults, internaloption.EnableDirectPath(true), internaloption.EnableDirectPathXds()) + defaults = append(defaults, + internaloption.EnableDirectPath(true), + internaloption.EnableDirectPathXds(), + internaloption.AllowNonDefaultServiceAccount(true)) } return defaults diff --git a/storage/integration_test.go b/storage/integration_test.go index 517c77a659d8..d2a3286bd4b8 100644 --- a/storage/integration_test.go +++ b/storage/integration_test.go @@ -327,7 +327,6 @@ var readCases = []readCase{ } func TestIntegration_DetectDirectConnectivity(t *testing.T) { - t.Skip("direct connectivity not yet available for CI") ctx := skipHTTP("direct connectivity isn't available for json") multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) { h := testHelper{t}