Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to standard protocol-buffer-matchers.h when available #4776

Closed
mr-salty opened this issue Aug 4, 2020 · 1 comment
Closed

migrate to standard protocol-buffer-matchers.h when available #4776

mr-salty opened this issue Aug 4, 2020 · 1 comment
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@mr-salty
Copy link
Contributor

mr-salty commented Aug 4, 2020

This is blocked on google/googletest#1761 - opening this issue to remind us to use it if/when that gets resolved.

While discussing a PR today, we had a potential need for IgnoringRepeatedFieldOrdering, and there are a number of nice features in there we could use, plus we can delete our own IsProtoEqual, etc.

At least one project has already externalized this; we could also just copy that to our tree. see https://github.com/google/nucleus/blob/master/nucleus/testing/protocol-buffer-matchers.h (and .cc)
@mr-salty mr-salty added the type: cleanup An internal cleanup or hygiene concern. label Aug 4, 2020
@ChristopherBrix ChristopherBrix mentioned this issue Sep 24, 2020
Merged
@devjgm
Copy link
Contributor

devjgm commented Jan 27, 2022

Looks like it won't happen any time soon. If it does one day, we can use them then.

@devjgm devjgm closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mr-salty @devjgm