Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Certificate Caching During Token Verification #178

Closed
hiranya911 opened this issue Jul 28, 2017 · 2 comments
Closed

Public Certificate Caching During Token Verification #178

hiranya911 opened this issue Jul 28, 2017 · 2 comments
Assignees
@theacodes
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@hiranya911
Copy link
Contributor

Token verification methods like verify_token() and verify_firebase_token() doesn't seem to be caching public certs. Is that correct? Do they make an HTTP request (in _fetch_certs()) on each invocation?

This is not necessarily a problem with the above methods, but with the default HTTP transport implementations provided in the library (the requests transport for example).
@dhermes
Copy link
Contributor

dhermes commented Jul 28, 2017

IIRC oauth2client does have a cache, but we intentionally didn't add one for google-auth at the outset.

@theacodes
Copy link
Contributor

Closing in favor of #218

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theacodes theacodes

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@theacodes @dhermes @hiranya911 @yoshi-automation