Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics (part 2) #1303

Merged
merged 1 commit into from
May 24, 2023
Merged

feat: add metrics (part 2) #1303

merged 1 commit into from
May 24, 2023

Conversation

arithmetic1728
Copy link
Contributor

This PR adds _metric_header_for_usage() method to compute engine/service account/user/impersonated access token credentials. This method returns cred-type/<the credential type> string, and this string will be added to API service request's x-goog-api-client headers.

previous PR: #1298

@arithmetic1728 arithmetic1728 merged commit ebd5af7 into main May 24, 2023
@arithmetic1728 arithmetic1728 deleted the metric2 branch May 24, 2023 20:30
gcf-merge-on-green bot pushed a commit that referenced this pull request May 25, 2023
This PR adds `x-goog-api-client` header to
- access token and id token refresh requests, for compute engine credentials / user credentials / service account credentials / impersonated credentials
- reauth start and continue requests
- metadata server ping requests

Previous PRs:
Part 1: #1298 
Part 2: #1303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants