Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove 3PI config url validation #1220

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

BigTailWolf
Copy link
Contributor

Remove the url validation for TPC support.
Failed configuration will be on user's own risk in future.

@BigTailWolf BigTailWolf requested review from a team as code owners February 1, 2023 18:55
@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@clundin25
Copy link
Contributor

nit: Using the $ git revert $COMMIT could be an easier way to revert this code. This will also result in self-documenting commits.

@lsirac
Copy link
Contributor

lsirac commented Feb 1, 2023

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

@BigTailWolf
Copy link
Contributor Author

nit: Using the $ git revert $COMMIT could be an easier way to revert this code. This will also result in self-documenting commits.

I considered that. But I found those validations are not added the same time. And very hard to find all these separate changes.

@BigTailWolf
Copy link
Contributor Author

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

Hi @lsirac , and for the is_workforce_pool, we also have regex matching there, that would fail TPC user's check.

@BigTailWolf BigTailWolf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 1, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2023
@lsirac
Copy link
Contributor

lsirac commented Feb 1, 2023

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

Hi @lsirac , and for the is_workforce_pool, we also have regex matching there, that would fail TPC user's check.

Yes, please update the regex as well

Let's keep it for now, and circle back on this

@BigTailWolf
Copy link
Contributor Author

Please update the README to mention that we do not validate the URLs in the config for Workload/Workforce

Hi @lsirac , and for the is_workforce_pool, we also have regex matching there, that would fail TPC user's check.

Yes, please update the regex as well

Let's keep it for now, and circle back on this

Good. Maybe need backlog a "loose the pattern check for is_workforce_pool"

lsirac
lsirac previously approved these changes Feb 1, 2023
@lsirac lsirac dismissed their stale review February 2, 2023 04:56

docs missing

@BigTailWolf BigTailWolf requested a review from a team as a code owner February 3, 2023 18:52
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
docs/user-guide.rst Outdated Show resolved Hide resolved
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2023
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2023
@BigTailWolf
Copy link
Contributor Author

@arithmetic1728 may I get an approval?

@BigTailWolf BigTailWolf merged commit 8b95515 into googleapis:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants