fix: Allow mtls sts endpoint for external account token urls. #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
arithmetic1728
approved these changes
Nov 15, 2022
lsirac
reviewed
Nov 15, 2022
clundin25
commented
Nov 15, 2022
lsirac
approved these changes
Nov 16, 2022
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| "https://us-east-1.sts.googleapis.com", | ||
| "https://us-east-1.sts.mtls.googleapis.com", | ||
| "https://US-EAST-1.sts.googleapis.com", | ||
| "https://sts.us-east-1.googleapis.com", | ||
| "https://sts.US-WEST-1.googleapis.com", |
There was a problem hiding this comment.
add a case for "https://sts.mtls.US-WEST-1.googleapis.com" (if that is allowed)?
There was a problem hiding this comment.
IIUC MTLS must prefix googleapis.com but I will check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.