Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding support to specify browser while launching browser to authention #305

Merged
merged 4 commits into from
Sep 7, 2023
Merged

feat: Adding support to specify browser while launching browser to authention #305

merged 4 commits into from
Sep 7, 2023

Conversation

anujmaurice
Copy link
Contributor

@anujmaurice anujmaurice commented Aug 19, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #303

@anujmaurice anujmaurice requested review from a team as code owners August 19, 2023 08:57
@google-cla
Copy link

google-cla bot commented Aug 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 19, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 19, 2023
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 19, 2023
@clundin25
Copy link
Contributor

clundin25 commented Aug 22, 2023 •
edited
Loading

Does the BROWSER environment variable work for you @anujmaurice ?

It did not seem to work for me on MacOS. I think this change is okay for that reason

@clundin25 clundin25 changed the title Adding support to specify browser while launching browser to authention feat: Adding support to specify browser while launching browser to authention Aug 22, 2023
clundin25
clundin25 reviewed Aug 22, 2023
View reviewed changes
google_auth_oauthlib/flow.py
@@ -379,6 +379,7 @@ def run_local_server(
redirect_uri_trailing_slash=True,
timeout_seconds=None,
token_audience=None,
browser=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this parameter to the doc string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clundin25 I have added the doc string

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 26, 2023
@anujmaurice
Copy link
Contributor Author

@clundin25 Can you please look into this. I have fixed the unit tests

@anujmaurice
Copy link
Contributor Author

@clundin25 I have fixed the black failures. lint should succeed now.

@anujmaurice
Copy link
Contributor Author

@clundin25 All the unittests have passed, is there anything more required from my side. Please let me know.

@clundin25 clundin25 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1a9dca8 into googleapis:main Sep 7, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 7, 2023
@release-please release-please bot mentioned this pull request Sep 7, 2023
Merged
@clundin25
Copy link
Contributor

This feature has now been released in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clundin25 clundin25 clundin25 approved these changes

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

Assignees
No one assigned
Labels
kokoro:run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to specify browser during authentication
4 participants
@anujmaurice @clundin25 @sai-sunder-s @dandhlee