Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for BYOID / STS #473

Merged
merged 7 commits into from
Sep 7, 2023
Merged

feat: add support for BYOID / STS #473

merged 7 commits into from
Sep 7, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Aug 25, 2023 •
edited
Loading

@bshaffer bshaffer mentioned this pull request Aug 25, 2023
Merged
3 tasks
@bshaffer bshaffer marked this pull request as ready for review August 25, 2023 17:48
@bshaffer bshaffer requested a review from a team as a code owner August 25, 2023 17:48
@bshaffer bshaffer changed the title feat: add support for STS feat: add support for BYOID / STS Aug 25, 2023
@bshaffer bshaffer mentioned this pull request Aug 25, 2023
Closed
aeitzman
aeitzman reviewed Aug 25, 2023
View reviewed changes
Copy link

@aeitzman aeitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits and suggestions for test cases to add.

src/CredentialSourceInterface.php Outdated Show resolved Hide resolved
src/OAuth2.php Show resolved Hide resolved
tests/CredentialSource/FileSourceTest.php Show resolved Hide resolved
tests/CredentialSource/UrlSourceTest.php Show resolved Hide resolved
tests/OAuth2Test.php Show resolved Hide resolved
vishwarajanand
vishwarajanand approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very neat, thanks!
Left a few nits.

src/CredentialSource/FileSource.php Show resolved Hide resolved
src/Credentials/ExternalAccountCredentials.php Outdated Show resolved Hide resolved
src/CredentialSource/UrlSource.php Outdated Show resolved Hide resolved
src/CredentialSource/UrlSource.php Outdated Show resolved Hide resolved
@bshaffer bshaffer merged commit 2938e58 into main Sep 7, 2023
@bshaffer bshaffer deleted the sts branch September 7, 2023 18:02
@release-please release-please bot mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeitzman aeitzman aeitzman approved these changes

@vishwarajanand vishwarajanand vishwarajanand approved these changes

@noahdietz noahdietz Awaiting requested review from noahdietz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @vishwarajanand @aeitzman