-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Backwards-Compatible Auth #1624
Conversation
|
…js into backwards-compatible-auth
test/fixtures/key.p12
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this related to the changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really; noticed it was an unused file that we can remove
@@ -28,7 +28,6 @@ describe('jwt', () => { | |||
const keypair = require('keypair'); | |||
const PEM_PATH = './test/fixtures/private.pem'; | |||
const PEM_CONTENTS = fs.readFileSync(PEM_PATH, 'utf8'); | |||
const P12_PATH = './test/fixtures/key.p12'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, was it just an unused value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, an unused value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…js into backwards-compatible-auth
…js into backwards-compatible-auth
This would introduce more complexity than is required to solve this problem; instead, we should encourage dependencies to expose their version of |
This will greatly improve the experience for customers transitioning between different versions of
google-auth-library
.Consumers can use the new
GoogleAuth.normalize
andAuthClient.normalize
APIs to ensure the providedGoogleAuth
andAuthClient
instances are compatible with the currentgoogle-auth-library
version.Example:
Fixes #1402 🦕