You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gitgrimbo opened this issue
Oct 15, 2018
· 1 comment
Assignees
Labels
🚨This issue needs some love.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
Fair point! That should never return null. Fix is over at #488
JustinBeckwith
added
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
priority: p2
Moderately-important priority. Fix may not be included in next release.
labels
Oct 15, 2018
🚨This issue needs some love.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
The docs:
https://googleapis.github.io/google-auth-library-nodejs/classes/_auth_oauth2client_.oauth2client.html#verifyidtoken
say
verifyIdToken()
can returnnull
in the returnedPromise
:Promise<LoginTicket | null>
but that doesn't seem possible.
This is causing (incorrect?) warnings in my TypeScript project.
The method:
google-auth-library-nodejs/src/auth/oauth2client.ts
Line 832 in fba5662
supposedly can return
null
in thePromise
.The
verifyIdToken()
method calls:google-auth-library-nodejs/src/auth/oauth2client.ts
Line 862 in fba5662
which calls the following code (JSDoc shown) (no mention of
null
in the JSDoc, and also seemingly no way for the method to returnnull
):google-auth-library-nodejs/src/auth/oauth2client.ts
Line 951 in fba5662
The text was updated successfully, but these errors were encountered: