Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util LRUCache: should evict items older than a supplied maxAge failed #1665

Closed
flaky-bot bot opened this issue Oct 10, 2023 · 4 comments
Closed

util LRUCache: should evict items older than a supplied maxAge failed #1665

flaky-bot bot opened this issue Oct 10, 2023 · 4 comments
Assignees
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 10, 2023

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 311d6a1
buildURL: Build Status, Sponge
status: failed

Test output
Expected values to be strictly equal:

1 !== undefined

/workspace/test/test.util.ts:62
assert.equal(lru.get('first'), undefined);
^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== undefined

at Context.<anonymous> (test/test.util.ts:62:14)</pre></details>
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 10, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Oct 11, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 11, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (311d6a1), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 17, 2023

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 56cb3ad
buildURL: Build Status, Sponge
status: failed

Test output
Expected values to be strictly equal:

1 !== undefined

/workspace/test/test.util.ts:62
assert.equal(lru.get('first'), undefined);
^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== undefined

at Context.<anonymous> (test/test.util.ts:62:14)</pre></details>

@sofisl sofisl added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 17, 2023
@danielbankhead
Copy link
Contributor

This is very strange... the error message reported is from a commit that doesn't match the most up-to-date state of main (as of the past week it seems).

@danielbankhead
Copy link
Contributor

Ah, nvm; I see I merged #1667 into the wrong branch 😅 This will be closed via: #1663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants