Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add External Account Authorized User client type #1530

Merged
merged 11 commits into from
Apr 13, 2023
Merged

feat: Add External Account Authorized User client type #1530

merged 11 commits into from
Apr 13, 2023

Conversation

aeitzman
Copy link
Contributor

Adds support for external account authorized user credentials.

See go/gcloud-3pi-headful.

@aeitzman aeitzman requested review from a team as code owners March 13, 2023 16:51
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Mar 13, 2023
@aeitzman aeitzman added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2023
lsirac
lsirac reviewed Apr 10, 2023
View reviewed changes
src/auth/externalAccountAuthorizedUserClient.ts Outdated Show resolved Hide resolved
src/auth/externalAccountAuthorizedUserClient.ts Outdated Show resolved Hide resolved
src/auth/externalAccountAuthorizedUserClient.ts Show resolved Hide resolved
test/test.googleauth.ts Show resolved Hide resolved
test/test.externalaccountauthorizeduserclient.ts Outdated Show resolved Hide resolved
test/test.externalaccountauthorizeduserclient.ts Outdated Show resolved Hide resolved
@danieljbruce
Copy link
Contributor

Looks like this PR has additional comments that need to be addressed before we can merge.

danielbankhead
danielbankhead approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few minor/optional changes

src/auth/externalAccountAuthorizedUserClient.ts Outdated Show resolved Hide resolved
src/auth/externalAccountAuthorizedUserClient.ts Outdated Show resolved Hide resolved
src/auth/externalAccountAuthorizedUserClient.ts Outdated Show resolved Hide resolved
@aeitzman aeitzman added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@aeitzman aeitzman added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 12, 2023
@aeitzman aeitzman merged commit 06d4ef3 into googleapis:main Apr 13, 2023
@release-please release-please bot mentioned this pull request Apr 13, 2023
Merged
@nc-minh nc-minh mentioned this pull request Aug 15, 2024
Open
This was referenced Sep 10, 2024
Open
Open
This was referenced Sep 16, 2024
Open
Open
This was referenced Sep 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsirac lsirac lsirac approved these changes

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees

@lsirac lsirac

Labels
kokoro:run Add this label to force Kokoro to re-run the tests. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aeitzman @danieljbruce @danielbankhead @lsirac @yoshi-kokoro