Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http command removes initial query parameters #319

Closed
railscard opened this issue Dec 14, 2015 · 1 comment
Closed

http command removes initial query parameters #319

railscard opened this issue Dec 14, 2015 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Milestone

Comments

@railscard
Copy link
Contributor

When I'm executing service http method using url with query values, HttpCommand completely replaces those query values with empty hash.

For example when I'm using this http method to download files using the export links from google drive, instead of this:

Sending HTTP get https://docs.google.com/feeds/download/documents/export/Export?id=someDocumentId&exportFormat=docx

I get this

Sending HTTP get https://docs.google.com/feeds/download/documents/export/Export?

I think it's not very convenient, so we should keep initial query parameters.
If you agree, I can make a PR (railscard@f51a4f2)

@sqrrrl
Copy link
Contributor

sqrrrl commented Dec 14, 2015

PR welcome. Please make sure to read the contributing guidelines and sign the CLA too.

@sqrrrl sqrrrl added this to the 0.9 milestone Dec 16, 2015
@sqrrrl sqrrrl closed this as completed Dec 16, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants