Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update deprecated utcnow, utcfromtimestamp #2286

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: update deprecated utcnow, utcfromtimestamp #2286

merged 2 commits into from
Dec 12, 2023

Conversation

salty-horse
Copy link
Contributor

Fixes #2285 🦕

The docs should be regenerated, since they mention the EPOCH constants. I'm not sure how to do that :(

@salty-horse salty-horse requested a review from a team as a code owner November 21, 2023 19:46
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 21, 2023
@parthea parthea self-assigned this Nov 27, 2023
@vchudnov-g vchudnov-g changed the title Replace deprecated utcnow, utcfromtimestamp fix: update deprecated utcnow, utcfromtimestamp Dec 8, 2023
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Dec 8, 2023 •
edited
Loading

Thanks for the PR, @salty-horse ! Could you link to the docs to which you refer that need updating?

@vchudnov-g vchudnov-g self-assigned this Dec 8, 2023
@salty-horse
Copy link
Contributor Author

The epy-generated docs for the two files I changed, which mention the old value of EPOCH:

docs/epy/googleapiclient.channel-pysrc.html
docs/epy/googleapiclient.discovery_cache.file_cache-module.html
docs/epy/googleapiclient.discovery_cache.file_cache-pysrc.html

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 12, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 12, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2023
@parthea parthea merged commit b3e5d38 into googleapis:main Dec 12, 2023
13 checks passed
@release-please release-please bot mentioned this pull request Dec 12, 2023
Merged
@parthea
Copy link
Contributor

parthea commented Dec 12, 2023

I filed #2300 to track the issue with the outdated docs

Scoring100
Scoring100 suggested changes Jan 21, 2024
View reviewed changes
Copy link

@Scoring100 Scoring100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete @briandorsey

googleapiclient/discovery_cache/file_cache.py
@@ -46,7 +46,7 @@
LOGGER = logging.getLogger(__name__)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**
**

tests/test_discovery.py
@@ -2193,7 +2193,7 @@ def _dummy_token(self):
client_id = "some_client_id"
client_secret = "cOuDdkfjxxnv+"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
client_secret = "cOuDdkfjxxnv+"
client_secret = "cOuDdkfjxxnv+"``

tests/test_discovery.py
@@ -2193,7 +2193,7 @@ def _dummy_token(self):
client_id = "some_client_id"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scoring100 Scoring100 Scoring100 requested changes

@parthea parthea parthea approved these changes

Assignees

@parthea parthea

@vchudnov-g vchudnov-g

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated utcnow, utcfromtimestamp should be removed
5 participants
@salty-horse @vchudnov-g @parthea @Scoring100 @yoshi-kokoro