Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct type for $jwt, should be JWT #2648

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

jose-ochoa
Copy link
Contributor

For #2641

This pull request includes changes to the Verify class in the src/AccessToken/Verify.php file to improve type safety by updating the type hints for the jwt property and constructor parameter.

Type safety improvements:

@jose-ochoa jose-ochoa requested a review from a team as a code owner December 16, 2024 16:24
Copy link

google-cla bot commented Dec 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jose-ochoa jose-ochoa force-pushed the 2641-Fix-JWT-Type-Error branch 2 times, most recently from ff50926 to 1e0adb1 Compare December 16, 2024 16:34
@jose-ochoa jose-ochoa force-pushed the 2641-Fix-JWT-Type-Error branch from 1e0adb1 to 74f2b17 Compare December 16, 2024 16:37
@bshaffer bshaffer merged commit 31a9861 into googleapis:main Dec 16, 2024
10 of 12 checks passed
@jose-ochoa jose-ochoa deleted the 2641-Fix-JWT-Type-Error branch December 17, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants