Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in guzzle for PHP Version 7.2.8 #1507

Closed
drrhf opened this issue Sep 4, 2018 · 5 comments
Closed

Bug in guzzle for PHP Version 7.2.8 #1507

drrhf opened this issue Sep 4, 2018 · 5 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@drrhf
Copy link

drrhf commented Sep 4, 2018

I'm not sure where to mention this, but google-api-php-client-2.22 (the latest I think) still fails with the 'count()' error discussed in guzzle/guzzle#1956 when using PHP Version 7.2.8. The problem does not occur with PHP Version 7.0.4.
I mentioned this on the guzzle forum but thought it appropriate to mention it here as well.

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Sep 5, 2018
@mattwhisenhunt mattwhisenhunt added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. labels Sep 5, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Sep 5, 2018
@mattwhisenhunt
Copy link
Contributor

Greetings @drrhf,

I was under the impression this got fixed. What's your version of guzzle (composer info)? Please attach a sample of code that reproduces this issue.

@drrhf
Copy link
Author

drrhf commented Sep 10, 2018

Matt,
I don't use Composer.
Rather I downloaded what I thought was the latest release: google-api-php-client-2.2.2.
Thanks,
Bob

@Renkas
Copy link

Renkas commented Nov 4, 2018

This is fixed in Guzzle 6.3

This library installs Guzzle 6.2.3 (at least it has done so for me). manually updating Guzzle in my project fixed this issue for me.

@mattwhisenhunt
Copy link
Contributor

@drrhf It looks like release 2.2.2 shipped with Guzzle 6.3.3. Can you verify those version numbers again (Guzzle's in vendor//ClientInterface.php) and mock up some code snippet that reproduces the error you are hitting?

@drrhf
Copy link
Author

drrhf commented Nov 5, 2018

You are correct. Somehow I was using a version of guzzle that had (in src\Handler\CurlFactory.php)
"private $handles;" In guzzle Version 6.3.3 this is replaced with "private $handles = [];" and the code works correctly with PHP Version 7.2.8.
Thanks,
Bob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants