Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GoogleAuthUtil.invalidateToken with GoogleAuthUtil.clearToken #950

Closed
erickoledadevrel opened this issue Jul 9, 2015 · 1 comment
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@erickoledadevrel
Copy link

It's used here:

https://github.com/google/google-api-java-client/blob/57fe35766cbba0a0d5a9a296be81468d730a29f8/google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java#L294

The method is deprecated due to requiring MANAGE_ACCOUNTS and USE_CREDENTIALS permissions:

https://developers.google.com/android/reference/com/google/android/gms/auth/GoogleAuthUtil#invalidateToken(android.content.Context, java.lang.String)

The replacement is GoogleAuthUtil.clearToken. This should allow Android developers to use the library without requesting those extra permissions.

@devconsole
Copy link

Also GoogleAccountCredential.setSelectedAccountName() requires GET_ACCOUNTS. It should delegate this work to Play Services instead. com.google.android.gms.common.api.GoogleApiClient does not require any account-related permissions and in my opinion neither should GoogleAccountCredential.

@mattwhisenhunt mattwhisenhunt added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 8, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

5 participants