Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle warnings #1162

Closed
elharo opened this issue Sep 18, 2018 · 0 comments
Closed

Checkstyle warnings #1162

elharo opened this issue Sep 18, 2018 · 0 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@elharo
Copy link
Contributor

elharo commented Sep 18, 2018

[INFO] --- maven-checkstyle-plugin:2.6:check (default) @ google-api-client ---
[INFO] Starting audit...
/Users/elharo/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:491: warning: First sentence should end with a period.
/Users/elharo/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:552: warning: First sentence should end with a period.
/Users/elharo/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java:754: Line is longer than 100 characters.
/Users/elharo/google-api-java-client/google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClient.java:34:23: warning: Variable 'logger' should be in ALL_CAPS (if it is a constant) or be private (otherwise).
Audit done.

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Sep 19, 2018
@chingor13 chingor13 added the type: cleanup An internal cleanup or hygiene concern. label Sep 19, 2018
@JustinBeckwith JustinBeckwith removed the triage me I really want to be triaged. label Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants