Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect expires_in value set by MockTokenServerTransport #1061

Closed
hiranya911 opened this issue Aug 18, 2017 · 0 comments
Closed

Incorrect expires_in value set by MockTokenServerTransport #1061

hiranya911 opened this issue Aug 18, 2017 · 0 comments
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@hiranya911
Copy link

https://github.com/google/google-api-java-client/blob/4fc8c099d9db5646770868cc1bc9a33c9225b3c7/google-api-client/src/main/java/com/google/api/client/googleapis/testing/auth/oauth2/MockTokenServerTransport.java#L119

expires_in is reported in seconds. Therefore it's more accurate to set 3600 here.
@hiranya911 hiranya911 mentioned this issue Aug 18, 2017
Closed
@JustinBeckwith JustinBeckwith added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. and removed status: investigating labels Jun 7, 2018
@chingor13 chingor13 self-assigned this Jan 5, 2019
@chingor13 chingor13 mentioned this issue Jan 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chingor13 @JustinBeckwith @hiranya911 @mattwhisenhunt