Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Thread.interrupted in MediaHttpDownload #1051

Open
markperona opened this issue Jun 9, 2017 · 1 comment
Open

Handling Thread.interrupted in MediaHttpDownload #1051

markperona opened this issue Jun 9, 2017 · 1 comment
Labels
priority: p4 type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@markperona
Copy link

I was wondering if you could make a change such as the following to handle stopping a download. The developer could interrupt the background Thread doing the download to stop it.

        if (mediaContentLength <= nextByteIndex || Thread.interrupted()) {
            // All required bytes have been downloaded from the server.
            bytesDownloaded = mediaContentLength;
            updateStateAndNotifyListener(DownloadState.MEDIA_COMPLETE);
            return;
        }
@mattwhisenhunt mattwhisenhunt added status: investigating type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Dec 22, 2017
@JustinBeckwith JustinBeckwith added 🚨 This issue needs some love. and removed status: investigating labels Jun 7, 2018
@JustinBeckwith JustinBeckwith removed the 🚨 This issue needs some love. label Jun 25, 2018
@andrey-qlogic
Copy link
Contributor

@markperona, @JustinBeckwith, @mattwhisenhunt this may be already fixed with #1101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p4 type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants