Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GCE detection by checking Google hardware #2117

Closed
TimurSadykov opened this issue Aug 16, 2023 · 3 comments · Fixed by googleapis/google-cloud-go#10521
Closed

Improve GCE detection by checking Google hardware #2117

TimurSadykov opened this issue Aug 16, 2023 · 3 comments · Fixed by googleapis/google-cloud-go#10521
Assignees
@quartzmo
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@TimurSadykov
Copy link

Current detection has elevated false-negative rate in certain environments and cause unrecoverable errors. To improve that we add a static detection of Google hardware.

Implement the stage 1 proposal per go/auth-library-noping
@TimurSadykov TimurSadykov added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 16, 2023
@codyoss
Copy link
Member

codyoss commented Apr 24, 2024

It seems like this got dropped. For many years Go has had the SMIBIOS check for linux, but we still need the check for Windows. We will get this scheduled soon.

@codyoss codyoss assigned quartzmo and unassigned codyoss Apr 24, 2024
@quartzmo
Copy link
Member

quartzmo commented Jun 7, 2024

Package wmi provides a WQL interface for WMI on Windows.

https://github.com/yusufpapurcu/wmi

@quartzmo
Copy link
Member

quartzmo commented Jun 7, 2024

DotNet implementation: https://github.com/googleapis/google-api-dotnet-client/blob/main/Src/Support/Google.Apis.Auth/OAuth2/ComputeCredential.cs#L442-L466

@codyoss codyoss mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(compute/metadata): add sys check for windows OnGCE codyoss/google-cloud-go
3 participants
@quartzmo @TimurSadykov @codyoss