Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Opencensus in favor of opentelemetry? #1493

Closed
jaronoff97 opened this issue Mar 29, 2022 · 10 comments
Closed

Remove Opencensus in favor of opentelemetry? #1493

jaronoff97 opened this issue Mar 29, 2022 · 10 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@jaronoff97
Copy link

Hello! I was wondering if there's been any effort or if it would be welcome upstream to remove opencensus as a dependency? Opencensus has been merged with opentracing to create opentelemetry, and opencensus will no longer be receiving security updates soon.

OpenCensus and OpenTracing have merged to form OpenTelemetry, which serves as the next major version of OpenCensus and OpenTracing. OpenTelemetry will offer backwards compatibility with existing OpenCensus integrations, and we will continue to make security patches to existing OpenCensus libraries for two years.

If it's welcome, I'd be able to migrate the opentracing usages to otel!

@jaronoff97 jaronoff97 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Mar 29, 2022
@jaronoff97 jaronoff97 changed the title Remove Opencensus Remove Opencensus in favor of opentelemetry? Mar 29, 2022
@codyoss
Copy link
Member

codyoss commented Mar 29, 2022

We do plan to support otel in the future, but I don't have a timeline on when this will be. We will need to make sure we don't break existing workflows that might expect opencensus traces etc. Also some of our libraries have needs for metics which is still not supported in the Go client, at least it is not stable.

There is also an issue that our libraries seem to provide more support for older runtimes. So until we support 1.16+ only I don't think we can use the latest versions of otel libraries. I will leave this issue open and post back when I know more.

@jaronoff97
Copy link
Author

great, thank you for letting me know!

@antoinedeschenes
Copy link

Honestly, providing a generic way to inject any custom Transport would be nice (in parallel to addOCTransport). You'd then have the choice to use otel or any other solution.

@codyoss
Copy link
Member

codyoss commented Jul 7, 2022

@antoinedeschenes You can kind of due this today with: https://pkg.go.dev/google.golang.org/api/option#WithHTTPClient

@antoinedeschenes
Copy link

@antoinedeschenes You can kind of due this today with: https://pkg.go.dev/google.golang.org/api/option#WithHTTPClient

Yeah, I looked into that, trying to add this through a bigquery.NewService, for example, involves a lot of reimplementation (custom header options, private method calls, internal packages, etc.) used to build the default http client, we quickly go down a rabbit hole.

@alexander-hirth
Copy link

The repo for opencensus https://github.com/census-instrumentation/opencensus-go says this:

All OpenCensus Github repositories will be archived on July 31st, 2023

It seems the time is come to remove the dependency on opencensus, and use opentelemetry.

@codyoss
Copy link
Member

codyoss commented Jun 15, 2023

Yes, I agree. We have started conversations about how we plan to move away from opencensus in the not too distant future.

@tmc
Copy link

tmc commented Aug 24, 2023

Any movement on this?

@quartzmo
Copy link
Member

quartzmo commented Jan 11, 2024

Trace context propagation support for OpenTelemetry was introduced in v0.154.0 via PR #2127.

The timeline for removing the trace context propagation support for OpenCensus (as well as the OpenCensus tracing support in several of the libraries in the google-cloud-go repo), is discussed here, along with examples of how to pass options to OpenTelemetry trace context propagation:

https://github.com/googleapis/google-cloud-go/blob/main/debug.md#opencensus

@jaronoff97
Copy link
Author

awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

6 participants