-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Opencensus in favor of opentelemetry? #1493
Comments
We do plan to support otel in the future, but I don't have a timeline on when this will be. We will need to make sure we don't break existing workflows that might expect opencensus traces etc. Also some of our libraries have needs for metics which is still not supported in the Go client, at least it is not stable. There is also an issue that our libraries seem to provide more support for older runtimes. So until we support 1.16+ only I don't think we can use the latest versions of otel libraries. I will leave this issue open and post back when I know more. |
great, thank you for letting me know! |
Honestly, providing a generic way to inject any custom Transport would be nice (in parallel to |
@antoinedeschenes You can kind of due this today with: https://pkg.go.dev/google.golang.org/api/option#WithHTTPClient |
Yeah, I looked into that, trying to add this through a bigquery.NewService, for example, involves a lot of reimplementation (custom header options, private method calls, internal packages, etc.) used to build the default http client, we quickly go down a rabbit hole. |
The repo for opencensus https://github.com/census-instrumentation/opencensus-go says this:
It seems the time is come to remove the dependency on opencensus, and use opentelemetry. |
Yes, I agree. We have started conversations about how we plan to move away from opencensus in the not too distant future. |
Any movement on this? |
Trace context propagation support for OpenTelemetry was introduced in v0.154.0 via PR #2127. The timeline for removing the trace context propagation support for OpenCensus (as well as the OpenCensus tracing support in several of the libraries in the google-cloud-go repo), is discussed here, along with examples of how to pass options to OpenTelemetry trace context propagation: https://github.com/googleapis/google-cloud-go/blob/main/debug.md#opencensus |
awesome, thank you! |
Hello! I was wondering if there's been any effort or if it would be welcome upstream to remove opencensus as a dependency? Opencensus has been merged with opentracing to create opentelemetry, and opencensus will no longer be receiving security updates soon.
If it's welcome, I'd be able to migrate the opentracing usages to otel!
The text was updated successfully, but these errors were encountered: