feat: add support for JSON data type #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
olavloite
commented
Sep 1, 2021
| @@ -146,6 +146,15 @@ func (r *rows) Next(dest []driver.Value) error { | |||
| } else { | |||
| dest[i] = nil | |||
| } | |||
| case sppb.TypeCode_JSON: | |||
There was a problem hiding this comment.
This and the below addition for ARRAY<JSON> are the only functional changes that are needed to support the new data type. All other changes are tests (and workarounds for tests on the emulator that does not yet support JSON).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new
JSONdata type.