Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky panic in TestSecondUpdateAborted_FirstResultUpdateCountChanged #262

Closed
olavloite opened this issue Jun 17, 2024 · 1 comment · Fixed by googleapis/google-cloud-go#10386
Closed

flaky panic in TestSecondUpdateAborted_FirstResultUpdateCountChanged #262

olavloite opened this issue Jun 17, 2024 · 1 comment · Fixed by googleapis/google-cloud-go#10386
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@olavloite
Copy link
Collaborator 

--- FAIL: TestSecondUpdateAborted_FirstResultUpdateCountChanged (0.01s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xf04b1a]

goroutine 59 [running]:
testing.tRunner.func1.2({0x114ed80, 0x1f20880})
	/opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1529 +0x39f
panic({0x114ed80, 0x1f20880})
	/opt/hostedtoolcache/go/1.20.14/x64/src/runtime/panic.go:884 +0x213
cloud.google.com/go/spanner.(*sessionPool).take(0x0, {0x1532e08, 0xc0001a6000})
	/home/runner/go/pkg/mod/cloud.google.com/go/[email protected]/session.go:1040 +0x9a
cloud.google.com/go/spanner.(*ReadWriteTransaction).begin(0xc0050e6c00, {0x1532e08, 0xc0001a6000})
	/home/runner/go/pkg/mod/cloud.google.com/go/[email protected]/transaction.go:1501 +0x346
cloud.google.com/go/spanner.NewReadWriteStmtBasedTransactionWithOptions({0x1532e08, 0xc0001a6000}, 0xc00058ed80, {{0x0, 0x0}, {0x0, 0x0}, 0x0, 0x0, 0x0})
	/home/runner/go/pkg/mod/cloud.google.com/go/[email protected]/transaction.go:1757 +0x385
github.com/googleapis/go-sql-spanner.(*conn).BeginTx(0xc0000c2c60, {0x1532e08?, 0xc0001a6000}, {0xc0008fba38?, 0x3d?})
	/home/runner/work/go-sql-spanner/go-sql-spanner/driver.go:976 +0x4fb
database/sql.ctxDriverBegin({0x1532e08, 0xc0001a6000}, 0xc0008fbd70, {0x1530fd0, 0xc0000c2c60})
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/ctxutil.go:104 +0x7b
database/sql.(*DB).beginDC.func1()
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/sql.go:1868 +0xc5
database/sql.withLock({0x152e318, 0xc000eea090}, 0xc0008fbb48)
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/sql.go:3405 +0x8c
database/sql.(*DB).beginDC(0xc001684a90, {0x1532e08, 0xc0001a6000}, 0xc000eea090, 0xc0000e3880, 0xc0008fbc20?)
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/sql.go:1864 +0xcf
database/sql.(*DB).begin(0xc000092630?, {0x1532e08, 0xc0001a6000}, 0x18?, 0x0?)
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/sql.go:1857 +0x94
database/sql.(*DB).BeginTx.func1(0x18?)
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/sql.go:1836 +0x45
database/sql.(*DB).retry(0x2?, 0xc0008fbca0)
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/sql.go:1538 +0x[47](https://github.com/googleapis/go-sql-spanner/actions/runs/9547977184/job/26314137777?pr=256#step:4:48)
database/sql.(*DB).BeginTx(0xc0001369c0?, {0x1532e08?, 0xc0001a6000?}, 0xc00007f540?)
	/opt/hostedtoolcache/go/1.20.14/x64/src/database/sql/sql.go:1835 +0x8a
github.com/googleapis/go-sql-spanner.testSecondUpdateAborted_FirstResultChanged(0xc0001369c0, 0x0, 0xc00007f760?)
	/home/runner/work/go-sql-spanner/go-sql-spanner/aborted_transactions_test.go:773 +0x106
github.com/googleapis/go-sql-spanner.TestSecondUpdateAborted_FirstResultUpdateCountChanged(0xc000136680?)
	/home/runner/work/go-sql-spanner/go-sql-spanner/aborted_transactions_test.go:726 +0x45
testing.tRunner(0xc0001369c0, 0x13fd200)
	/opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1629 +0x3ea
exit status 2
FAIL	github.com/googleapis/go-sql-spanner	0.4[55](https://github.com/googleapis/go-sql-spanner/actions/runs/9547977184/job/26314137777?pr=256#step:4:56)s
Error: Process completed with exit code 1.
@olavloite olavloite added the type: process A process-related concern. May include testing, release, or the like. label Jun 17, 2024
@olavloite
Copy link
Collaborator Author

Caused by googleapis/google-cloud-go#10385

This was referenced Jun 17, 2024
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(spanner): prevent possible panic for Session not found errors googleapis/google-cloud-go
1 participant
@olavloite