Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest release (1.8.5) breaks for node 6.10 on [email protected] #86

Closed
nishant-lbb opened this issue Apr 26, 2019 · 12 comments
Closed
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@nishant-lbb
Copy link

nishant-lbb commented Apr 26, 2019

Getting this : node_modules/gaxios/build/src/index.js:28
async function request(opts) {
^^^^^^^^
SyntaxError: Unexpected token function

@kubicle
Copy link

kubicle commented Apr 26, 2019

We get the same one.
Why was dropping node 6 released as a "patch" version, is this normal?

@AndrewSolonovich
Copy link

AndrewSolonovich commented Apr 26, 2019

Have the same issue. Is there a possible workaround?
BTW our version of node is 6.17 (latest docker node 6)

@nishant-lbb
Copy link
Author

I explicitly defined gaxios: 1.8.4 as a top level dependency. That seemed to work for us.

@ThamiduNaveen
Copy link

ThamiduNaveen commented Apr 26, 2019

/user_code/node_modules/firebase-admin/node_modules/gaxios/build/src/index.js:28
async function request(opts) {
^^^^^^^^

SyntaxError: Unexpected token function
fails the firebase-admin

@kechkibet
Copy link

Following, breaks my firebase functions when i try to use admin

@m4recek
Copy link

m4recek commented Apr 26, 2019

Cant deploy our Firebase projects on Node 6 because of this. Dropping Node version should be done as major release.

@kechkibet
Copy link

I had to change the engine on firebase functions to node 8 for it to work. as per this link:
https://firebase.google.com/docs/functions/manage-functions

"engines": {"node": "8"}

@m4recek
Copy link

m4recek commented Apr 26, 2019

@kechkibet there is a unfixed problem with Node 8 in Firebase firebase/firebase-functions#429

@JustinBeckwith
Copy link
Contributor

Greetings folks! Apologies for the problems. This was supposed to be a semver major bump, and something went wrong in the automated release machinery. I un-published [email protected], and ensured the dist tag is set to [email protected]. We will be digging into what happened here today.

Can someone delete their package-lock.json, npm install, and verify this still works?

@m4recek
Copy link

m4recek commented Apr 26, 2019

It works. Thank you for quick resolution :)

@ThamiduNaveen
Copy link

@m4recek is that connection error on 8 appear frequently?. In which cases that appear?

@m4recek
Copy link

m4recek commented Apr 29, 2019

@ThamiduNaveen very frequently, we have scraped production update to Node 8 because of it. More is here firebase/firebase-functions#429

@yoshi-automation yoshi-automation added triage me I really want to be triaged. labels Apr 6, 2020
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

8 participants