Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node-fetch dependency to v3.2 #508

Closed
adarshmadrecha opened this issue Oct 16, 2022 · 3 comments · Fixed by #617
Closed

Upgrade node-fetch dependency to v3.2 #508

adarshmadrecha opened this issue Oct 16, 2022 · 3 comments · Fixed by #617
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@adarshmadrecha
Copy link

Is your feature request related to a problem? Please describe.
When using firebase-admin in Nuxt3 Project along with Mongoose, it causes clash becase of use of different versions of node-fetch by underlying libraries.

image
image

Describe the solution you'd like
Upgrade to latest version of node-fetch i.e. 3.2.x

Describe alternatives you've considered
Have added overrides in the package.json, but it does not work because of the way it is imported in the gaxios.

"overrides": {
      "node-fetch": "3.2.10"
 }

image

Additional context

@adarshmadrecha adarshmadrecha added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 16, 2022
@ddelgrosso1
Copy link
Contributor

Hi @adarshmadrecha thanks for opening this issue. Currently we are unable to update to node-fetch 3.x as it has moved to a pure ESM package. Please see #429 for additional context.

@mbrevda
Copy link

mbrevda commented Jan 18, 2024

as it has moved to a pure ESM package

It would be great if you can elaborate more on how moving to a pure esm package creates a blocker?

@adarshmadrecha
Copy link
Author

As mentioned in #429 (comment)
Starting with node v21, this issue will have to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants