-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you have a plant to update node-fetch to v3? #445
Comments
We need to wait until we can drop support for Node 10. When that happens, we will look into updating node-fetch to v3, but it appears to be a non-trivial upgrade. Dropping of Node 10 is planned, but there is not an official timeline yet. |
@chingor13 node 10 has been dropped already. Here is the official timeline https://github.com/nodejs/Release And I agree it's not trivial because it requires all packages depending on the node-fetch 3 to be migrated from CommonJS to ESM. Why don't you just make a new gaxios v3 beta branch and release it with ESM support to kick off the migration? |
That is exactly what I missed when I create this issue. creating a beta branch looks good to me. |
@yumetodo here is a workaround I use:
|
Well, you can still import esm only modules from cjs without switching to ESM yourself once such example could be to do: const fetchPromise = import('node-fetch').then(mod => mod.default)
const fetch = (...args) => fetchPromise.then(fetch => fetch(...args)) |
Already, renovate-bot create #426 to introduce node-fetch v3 and it was rejected.
I'm interested in node-fetch/node-fetch#667 and it is fixed in node-fetch v3.
Do you have a plant to update node-fetch to v3?
The text was updated successfully, but these errors were encountered: