Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaxStreamingRetries retries when retryCodes is an empty array #1577

Closed
leahecole opened this issue Mar 27, 2024 · 2 comments · Fixed by #1578
Closed

gaxStreamingRetries retries when retryCodes is an empty array #1577

leahecole opened this issue Mar 27, 2024 · 2 comments · Fixed by #1578
Assignees
@leahecole
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@leahecole
Copy link
Contributor

The default retry strategy for server streaming retries does not consider the very common case that retryCodes is an empty array - in this case, we should not retry.
@leahecole leahecole added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 27, 2024
@leahecole leahecole self-assigned this Mar 27, 2024
@leahecole leahecole mentioned this issue Mar 27, 2024
Merged
@leahecole leahecole reopened this Mar 29, 2024
@leahecole
Copy link
Contributor Author

This may still be an issue for normalCalls - I'm working on investigating it after internal bug 330914422 was opened. There is a test that's supposed to check for it that was passing, and I need to investigate more to understand it all better.

@leahecole
Copy link
Contributor Author

I think that this is WAI for normal calls but will reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leahecole leahecole

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't retry server streaming calls if retryCodes is the empty array leahecole/gax-nodejs
1 participant
@leahecole