Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

SampleGen: initializing map fields #2943

Closed
2 of 4 tasks
yihanzhen opened this issue Aug 19, 2019 · 4 comments
Closed
2 of 4 tasks

SampleGen: initializing map fields #2943

yihanzhen opened this issue Aug 19, 2019 · 4 comments
Assignees
@yihanzhen
Labels
Core: Sample-gen priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@yihanzhen
Copy link
Contributor

yihanzhen commented Aug 19, 2019 •
edited
Loading

  • - In Java: the key should be boxed type (Integer)
  • - In C#: the format is broken
  • - In Python: we need to use objects instead of dictionaries when used as a map value (to be verified)
  • - In Node.js: there seems to be an extra comma(?)
@yihanzhen yihanzhen self-assigned this Aug 19, 2019
@yihanzhen yihanzhen added Core: Sample-gen priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 19, 2019
@yihanzhen
Copy link
Contributor Author

cc @googleapis/samplegen

@yihanzhen yihanzhen mentioned this issue Aug 19, 2019
Merged
@yihanzhen
Copy link
Contributor Author

yihanzhen commented Aug 21, 2019 •
edited
Loading

#2946 fixes Java and Node.js

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Aug 28, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Sep 7, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Sep 18, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Sep 28, 2019
@yihanzhen yihanzhen added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 13, 2019
@vchudnov-g vchudnov-g added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 4, 2020
@vchudnov-g
Copy link
Contributor

Lowering priority as we are pausing samplegen work for now.

@yihanzhen
Copy link
Contributor Author

Moved to backlog: https://github.com/googleapis/gapic-generator/wiki/feature-backlog/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihanzhen yihanzhen

Labels
Core: Sample-gen priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vchudnov-g @yihanzhen @yoshi-automation