Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bi-directional streaming calls with extra options #425

Closed
alexander-fenster opened this issue Apr 15, 2020 · 2 comments · Fixed by #1066
Closed

bi-directional streaming calls with extra options #425

alexander-fenster opened this issue Apr 15, 2020 · 2 comments · Fixed by #1066
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@alexander-fenster
Copy link
Contributor

Based on the discussion here:

- return this.innerApiCalls.listen(options);
+ return this.innerApiCalls.listen({}, options);

@schmidt-sebastian wrote:

I do think the generated code is busted here. We use options to set an additional header, but the way this gets passed down here is as the request (if I remember this correctly). If we don't modify the code, the header is dropped. This only affects bidirectional streaming APIs with additional metadata, so probably just us. I do think we should fix this upstream at some point.

We need to figure out what's wrong there, and fix it in the generator.

@alexander-fenster alexander-fenster added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Apr 15, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 16, 2020
@hkdevandla hkdevandla added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Apr 22, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 22, 2020
@hkdevandla hkdevandla added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 22, 2020
@alexander-fenster
Copy link
Contributor Author

Looks like #1066 fixes this one?

@summer-ji-eng
Copy link
Collaborator

Looks like #1066 fixes this one?

Looks like #1066 fixes this one?

Yes. Thanks for reference. Merge now. Will release new version with this change after Jan 2022 due to the code freeze policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants