From 582113992b2875558896b8cbdefa557aa1d25afb Mon Sep 17 00:00:00 2001 From: Peter Lamut Date: Mon, 15 Mar 2021 10:07:49 +0100 Subject: [PATCH 1/2] fix: correct retry deadline in publisher methods --- .../%name_%version/%sub/services/%service/transports/base.py.j2 | 1 + 1 file changed, 1 insertion(+) diff --git a/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/base.py.j2 b/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/base.py.j2 index c2db7df705..166bb7b0ac 100644 --- a/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/base.py.j2 +++ b/gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/base.py.j2 @@ -118,6 +118,7 @@ class {{ service.name }}Transport(abc.ABC): exceptions.{{ ex.__name__ }}, {%- endfor %} ), + deadline={{ method.timeout }}, ), {%- endif %} default_timeout={{ method.timeout }}, From 3993e65c62f8b93ee03326f370670e579e6c65f2 Mon Sep 17 00:00:00 2001 From: Peter Lamut Date: Tue, 16 Mar 2021 14:02:23 +0100 Subject: [PATCH 2/2] Add Retry timeout to ads and async template --- .../%name/%version/%sub/services/%service/transports/base.py.j2 | 1 + .../%name_%version/%sub/services/%service/async_client.py.j2 | 1 + 2 files changed, 2 insertions(+) diff --git a/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2 b/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2 index f25ba96a1a..29f8c2df9a 100644 --- a/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2 +++ b/gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2 @@ -93,6 +93,7 @@ class {{ service.name }}Transport(metaclass=abc.ABCMeta): exceptions.{{ ex.__name__ }}, {%- endfor %} ), + deadline={{ method.timeout }}, ), {%- endif %} default_timeout={{ method.timeout }}, diff --git a/gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2 b/gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2 index c0e2c9a6ac..6fd4e482ec 100644 --- a/gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2 +++ b/gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2 @@ -254,6 +254,7 @@ class {{ service.async_client_name }}: exceptions.{{ ex.__name__ }}, {%- endfor %} ), + deadline={{ method.timeout }}, ), {%- endif %} default_timeout={{ method.timeout }},