From b4782abb0a9fce1e2c79b3bd291b4a7e50729b61 Mon Sep 17 00:00:00 2001 From: Dov Shlachter Date: Thu, 17 Sep 2020 08:30:00 -0700 Subject: [PATCH] fix: 'id' should not be a reserved name A number of python builtins collide with flattened fields from certain API methods. More common names, especially ones that conflict with builtins that aren't used by the surface, are explicitly allowed. --- gapic/utils/reserved_names.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gapic/utils/reserved_names.py b/gapic/utils/reserved_names.py index 866a867663..14958fc52f 100644 --- a/gapic/utils/reserved_names.py +++ b/gapic/utils/reserved_names.py @@ -24,6 +24,6 @@ RESERVED_NAMES = frozenset( itertools.chain( keyword.kwlist, - set(dir(builtins)) - {"filter", "map"}, + set(dir(builtins)) - {"filter", "map", "id"}, ) )