Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated tests for python-<API> are not complete #837

Closed
Shabirmean opened this issue Apr 7, 2021 · 3 comments
Closed

Generated tests for python-<API> are not complete #837

Shabirmean opened this issue Apr 7, 2021 · 3 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@Shabirmean
Copy link
Member

Shabirmean commented Apr 7, 2021 •
edited
Loading

The re-generated tests in some PRs are in-complete. This is related to the keyword policy being added to reserved names list, thus requiring a rename of the use of policy in the library to something like policy_

PR#50 of grafeas : Failing tests
PR#51 of grafeas : Failing tests
PR#18 of python-binary-authorization : Failing tests
PR#112 of python-containeranalysis : Failing tests
PR#12 of python-artifact-registry : Failing tests

Also related: #835
@Shabirmean Shabirmean added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Apr 7, 2021
@Shabirmean Shabirmean mentioned this issue Apr 7, 2021
Closed
1 task
@Shabirmean Shabirmean changed the title Generated tests for python-binary-authorization are not complete Generated tests for python-<API> are not complete Apr 7, 2021
This was referenced Apr 7, 2021
Closed
Closed
Closed
Closed
Closed
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 8, 2021
@software-dov
Copy link
Contributor

@Shabirmean how serious would you say this issue is? Does it require immediate attention, or does it just block gapic regeneration?

@Shabirmean
Copy link
Member Author

@software-dov - I'd share the same as shared by @busunkim96 here.

For the python-cloudbuild, python-artifact-registry and python-containeranalysis it seems like it's just the gapic regeneration. However for python-grafeas there are features that are not merged in due to this blocker.

@vam-google vam-google added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. 🚨 This issue needs some love. labels May 10, 2021
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label May 11, 2021
@software-dov
Copy link
Contributor

Closing due to test coverage now being complete. Can reopen the issue if it resurfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@software-dov @Shabirmean @vam-google @yoshi-automation