fix: remove duplicate assignment of certain flattened, repeated fields #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for googleapis#756. Under certain circumstances, flattened, repeated fields could be duplicated during request construction.
software-dov
requested review from
BenRKarl,
vchudnov-g,
busunkim96 and
arithmetic1728
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1619 1619
Branches 328 328
=========================================
Hits 1619 1619 Continue to review full report at Codecov.
|
|
Generated surface has been eyeball tested; the bug described in the issue has been resolved. |
arithmetic1728
approved these changes
Feb 2, 2021
software-dov
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 2, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [0.40.6](https://www.github.com/googleapis/gapic-generator-python/compare/v0.40.5...v0.40.6) (2021-02-02) ### Bug Fixes * remove duplicate assignment of certain flattened, repeated fields ([#760](https://www.github.com/googleapis/gapic-generator-python/issues/760)) ([cdbc221](https://www.github.com/googleapis/gapic-generator-python/commit/cdbc22130a176e733c529f60a6b8b1d224e82e89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #756. Under certain circumstances, flattened, repeated fields
could be duplicated during request construction.