Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wrong unit test #502

Merged
merged 1 commit into from
Jul 8, 2020
Merged

fix: fix wrong unit test #502

merged 1 commit into from
Jul 8, 2020

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Jul 8, 2020

Endpoints are wrong in some tests.

Endpoint shouldn't be hard coded unless it is explicitly provided in client_options, otherwise it should be client.DEFAULT_ENDPOINT or client.DEFAULT_MTLS_ENDPOINT.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #502   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1487      1487           
  Branches       303       303           
=========================================
  Hits          1487      1487           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063625b...a91ff7a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants