Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service and version to fixup script #488

Closed
busunkim96 opened this issue Jun 26, 2020 · 1 comment
Closed

Add service and version to fixup script #488

busunkim96 opened this issue Jun 26, 2020 · 1 comment
Assignees
@software-dov
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@busunkim96
Copy link
Contributor

One library can have multiple keyword scripts. This may be because it has multiple API versions (v1, v2) or different APIs (firestore and firestore admin).

https://github.com/googleapis/gapic-generator-python/blob/161e48613934058780f82e15f71cbc9f574fdf65/gapic/templates/scripts/fixup_keywords.py.j2
@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 26, 2020
@software-dov software-dov mentioned this issue Jun 29, 2020
Merged
@software-dov
Copy link
Contributor

Fixed by #490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@software-dov software-dov

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@software-dov @busunkim96