Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client classes have factory functions from service account credential files #244

Closed
software-dov opened this issue Nov 13, 2019 · 1 comment
Closed

Client classes have factory functions from service account credential files #244

software-dov opened this issue Nov 13, 2019 · 1 comment
Assignees
@software-dov
Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@software-dov
Copy link
Contributor

The GAPIC monolith generates clients that have factory functions that accept the path to a credential file, use it to create an oauth Credentials object, and pass it into the class's constructor.

The microgenerator needs to create a similar factory for feature parity.
@software-dov software-dov added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. generator Bugs, features, and so forth pertaining to the generated client surface labels Nov 13, 2019
@software-dov software-dov self-assigned this Nov 13, 2019
@software-dov software-dov mentioned this issue Nov 15, 2019
Merged
@software-dov
Copy link
Contributor Author

Implemented by #246

@tseaver tseaver mentioned this issue Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@software-dov software-dov

Labels
generator Bugs, features, and so forth pertaining to the generated client surface priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@software-dov