Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: syntax fix for required_fields struct in rest transport #1103

Merged
merged 4 commits into from
Dec 9, 2021
Merged

fix: syntax fix for required_fields struct in rest transport #1103

merged 4 commits into from
Dec 9, 2021

Conversation

software-dov
Copy link
Contributor

No description provided.

@software-dov software-dov requested review from a team as code owners December 9, 2021 01:27
@software-dov software-dov linked an issue Dec 9, 2021 that may be closed by this pull request
Issues with gapic generator python version 0.58.0 #1102
Closed
kbandes
kbandes approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@kbandes kbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

parthea
parthea requested changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an issue with unused imports in grpc based clients where this line is importing json_format which is guarded by {% if service.has_lro %} regardless of grpc or rest based transport but the usage here is only for rest clients.

@software-dov software-dov requested a review from parthea December 9, 2021 18:36
@software-dov software-dov added the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2021
parthea
parthea reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one observation, otherwise LGTM

@software-dov software-dov requested a review from parthea December 9, 2021 21:38
@software-dov software-dov merged commit 3d7128c into googleapis:master Dec 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2021
This was referenced Jan 18, 2022
Merged
Closed
Closed
This was referenced Jan 26, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@kbandes kbandes kbandes approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@atulep atulep Awaiting requested review from atulep

@vam-google vam-google Awaiting requested review from vam-google

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with gapic generator python version 0.58.0
3 participants
@software-dov @kbandes @parthea