Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAPIC v2: need new surface for LRO client, and need v2 surfaces to use it #700

Open
2 of 3 tasks
noahdietz opened this issue Apr 2, 2024 · 5 comments
Open
2 of 3 tasks
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. v2 Issues and features set to release with the gapic generator v2

Comments

@noahdietz
Copy link
Collaborator

noahdietz commented Apr 2, 2024

It was pointed out that we are still using the "old gapic surface" in our generated LRO client. This client is a dependency of all GAPICs with LRO functionality. They use it under the hood and we will need to change GAPIC internals for "new surface" clients to use that "new surface" LRO.

They also have an accessor to make this client available to end users. This means that if we change the LRO client surface initialized for v2 surface clients, we will create a breaking change. As such, we need to come up with a means of mitigating the breakage.

Tasks:

  • generate "new surface" for LRO package
  • release "new surface" for LRO package
  • add "new surface" usage into "new surface" gapic generated code
@noahdietz noahdietz added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 2, 2024
@noahdietz
Copy link
Collaborator Author

cc: @ajupazhamayil @saranshdhingra

@noahdietz noahdietz self-assigned this Apr 2, 2024
@noahdietz
Copy link
Collaborator Author

cl/621250900 to enable "new surface" generation (hopefully)

@noahdietz
Copy link
Collaborator Author

bazel rule update was merged and I confirmed that the generated asset contains the "new surface" client as well. Waiting for automation to produce it in a PR here.

@noahdietz
Copy link
Collaborator Author

googleapis/google-cloud-php#7196 contains the regen

@noahdietz
Copy link
Collaborator Author

Reassigning to Brent for now, he offered to get the LRO gapic v2 surface generated.

@bshaffer bshaffer added the v2 Issues and features set to release with the gapic generator v2 label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. v2 Issues and features set to release with the gapic generator v2
Projects
None yet
Development

No branches or pull requests

2 participants