-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RevokeRefreshToken does not revoke token #204
Comments
I also wanted to mention a few things:
|
I am also facing the same issue. |
@christopherseeley , assigning over to you. Could please take a look? Thanks, |
Fixed in 24.4.0 |
@christopherseeley Is there a new way to revoke? Now I receive the following error, with my existing code: "Failed to revoke refresh token." Still using the method Google.Api.Ads.Common.OAuth.AdsOAuthProviderImpl.RevokeRefreshToken() I build the AdWordsAppConfig object and pass it in to a new OAuth2ProviderForApplications as the parameter, before I issue the RevokeRefreshToken method. The Error property of the exception has the following: {Error:"invalid_request", Description:"Bad Request", Uri:""} |
Here's the full stack trace: at Google.Api.Ads.Common.OAuth.AdsOAuthProviderImpl.RevokeRefreshToken() |
Found the issue. The method now requires the access and refresh tokens to be supplied. Previously, it worked with just the refresh token. Code adjusted and I'm able to successfully revoke, now. |
When attempting to revoke the refresh token with OAuth2ProviderForApplications.RevokeRefreshToken(), I do not receive any errors, yet the application remains in the permissions list (https://myaccount.google.com/permissions)
According to the method description, the token must be generated in "Offline Mode". When using the provider OAuth2ProviderForApplications, the default value for IsOffline is "true" so that suggests that it's already set to offline.
I have been using the same code for several months with success, but it didn't fail until I recently updated to the latest libraries.
Please let me know if more information is required.
The text was updated successfully, but these errors were encountered: