Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

//xla/service/cpu:vectorized_reduce_with_no_vector_registers_test fails on Apple Silicon #19830

Closed
majnemer opened this issue Nov 26, 2024 · 3 comments · Fixed by #19893 or tensorflow/tensorflow#80968 · May be fixed by google/tsl#2955
Closed

//xla/service/cpu:vectorized_reduce_with_no_vector_registers_test fails on Apple Silicon #19830

majnemer opened this issue Nov 26, 2024 · 3 comments · Fixed by #19893 or tensorflow/tensorflow#80968 · May be fixed by google/tsl#2955
Assignees
@d0k

Comments

@majnemer
Copy link
Contributor

Running this test results in:

[ RUN      ] CodegenReduceOnArchWithNoVectorRegisters.Test
xla/service/cpu/vectorized_reduce_with_no_vector_registers_test.cc:103: Failure
Value of: _status_or_value15.status().ok()
  Actual: false
Expected: true
INTERNAL: TargetRegistry::lookupTarget failed: No available targets are compatible with triple "i686-none-android"
[  FAILED  ] CodegenReduceOnArchWithNoVectorRegisters.Test (4 ms)
[----------] 1 test from CodegenReduceOnArchWithNoVectorRegisters (4 ms total)

I believe we do not link this target in on Apple Silicon builds which results in this failure. We should probably skip this test on non-x86 machines.
@majnemer
Copy link
Contributor Author

@d0k, can you please take a look?

@d0k
Copy link
Member

d0k commented Nov 27, 2024

It is tagged tags = ["not_run:arm"], why is it running in Apple Silicon builds?

@majnemer
Copy link
Contributor Author

I think TAP respects that tag but bazel itself does not seem to do so.

It seems that the supported way to do this is via:

    target_compatible_with = [
        "@platforms//cpu:x86_64",
    ]

copybara-service bot pushed a commit that referenced this issue Nov 27, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
6e05e30 
…uiring x86_64

Fixes #19830

Reverts 00f3b02

PiperOrigin-RevId: 700746361
@copybara-service copybara-service bot mentioned this issue Nov 27, 2024
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this issue Nov 27, 2024
@d0k @tensorflower-gardener
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
54afa42 
…uiring x86_64

Fixes openxla/xla#19830

Reverts e67b710

PiperOrigin-RevId: 700746361
@copybara-service copybara-service bot mentioned this issue Nov 27, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Nov 27, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
5bc8da8 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this issue Nov 27, 2024
@d0k @tensorflower-gardener
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
47ac3d4 
…uiring x86_64

Fixes openxla/xla#19830

Reverts e67b710

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit to google/tsl that referenced this issue Nov 27, 2024
@d0k @copybara-github
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
c861242 
…uiring x86_64

Fixes openxla/xla#19830

PiperOrigin-RevId: 700746361
@copybara-service copybara-service bot mentioned this issue Nov 27, 2024
Open
copybara-service bot pushed a commit that referenced this issue Nov 27, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
7ce7e7b 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit that referenced this issue Nov 27, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
adcea5c 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit that referenced this issue Nov 27, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
aa59352 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit that referenced this issue Nov 27, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
50631e4 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this issue Nov 28, 2024
@d0k @tensorflower-gardener
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
6ebc807 
…uiring x86_64

Fixes openxla/xla#19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit that referenced this issue Nov 28, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
4f512c8 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this issue Nov 28, 2024
@d0k @tensorflower-gardener
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
f4d9a06 
…uiring x86_64

Fixes openxla/xla#19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit that referenced this issue Nov 28, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
3ecdf99 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit that referenced this issue Nov 29, 2024
@d0k @Google-ML-Automation
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
ce2e769 
…uiring x86_64

Fixes #19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this issue Nov 29, 2024
@d0k @tensorflower-gardener
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
be2b5dc 
…uiring x86_64

Fixes openxla/xla#19830

PiperOrigin-RevId: 700746361
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this issue Nov 29, 2024
@d0k @tensorflower-gardener
[XLA:CPU] Mark vectorized_reduce_with_no_vector_registers_test as req…
46093a9 
…uiring x86_64

Fixes openxla/xla#19830

PiperOrigin-RevId: 701300312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d0k d0k

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@d0k @majnemer