Crash in kmlwriter

[bdferris]

From [email protected] on November 25, 2011 03:04:51

Users discovered an issue when running kmlwriter.py on a feed. The feed validates but there are warnings: "This stop time has a pickup_type and drop_off_type of 1, indicating that riders can't get on or off here. Since it doesn't define a timepoint either, this entry serves no purpose and should be excluded from the trip"
This warning seems to be responsible for the failing kmlwriter.py saying: "AttributeError: 'NoneType' object has no attribute 'OtherProblem'"

After a quick look into the code the Trip object's GetPattern method seems to be the problem here. It calls GetStopTimes without any attribute but GetStopTimes expectes a problems object that's set to None otherwise. Adding the found problem to this None object fails of course.

Original issue: http://code.google.com/p/googletransitdatafeed/issues/detail?id=316

[bdferris]

From [email protected] on November 25, 2011 03:05:52

(No comment was entered for this change.)

Blocking: 314

[bdferris]

From [email protected] on November 25, 2011 04:38:41

Reviewed at http://codereview.appspot.com/5431074/ and committed in r1638 .

Status: Fixed