Bug in TooManyConsecutiveStopTimesWithSameTime check when stop times are undefined

[bdferris]

From [email protected] on November 01, 2011 05:28:40

There is a bug in the way the TooManyConsecutiveStopTimesWithSameTime check is currently implemented.  Specifically, if you have a series of stop times like:

TripA,StopA,7:00:00,7:00:00,1
TripA,StopB,,,2
TripA,StopC,,,3
TripA,StopD,,,4
TripA,StopE,,,5
TripA,StopF,,,6
TripA,StopG,7:30:00,7:30:00,7

The current validator will throw a warning that there are 6 consecutive stop times all with the same time (7:00) because the stop times with missing arrival and departure times (indicating they should be interpolated) are considered to have the same time as the first stop time.  This is a bug.

Of course, we still want to be able to catch situations like:

TripA,StopA,7:00:00,7:00:00,1
TripA,StopB,,,2
TripA,StopC,,,3
TripA,StopD,,,4
TripA,StopE,,,5
TripA,StopF,,,6
TripA,StopG,7:00:00,7:00:00,7

Where there is a sequence of stop times with no arrival or departure time set sandwiched between two stop times that DO have the same time.

Original issue: http://code.google.com/p/googletransitdatafeed/issues/detail?id=310

[bdferris]

From [email protected] on November 01, 2011 05:29:06

(No comment was entered for this change.)

Blocking: 308

[bdferris]

From [email protected] on November 01, 2011 07:32:17

Reviewed in http://codereview.appspot.com/5319066/ and committed in r1620 .

Status: Fixed