Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.68 build failing on windows in upb message.c #205

Open
toloudis opened this issue Nov 20, 2024 · 2 comments
Open

0.1.68 build failing on windows in upb message.c #205

toloudis opened this issue Nov 20, 2024 · 2 comments

Comments

@toloudis
Copy link

toloudis commented Nov 20, 2024

_deps\protobuf-src\upb\message\internal\message.c(22): error C2099: initializer is not a constant

https://github.com/allen-cell-animated/agave/actions/runs/12002323672/job/33454115539

Looks like the same error mentioned in grpc/grpc#37210

@toloudis toloudis changed the title 0.1.68 build failing to find google/storage/v2/storage.pb.h 0.1.68 build failing on windows in upb message.c Nov 25, 2024
@laramiel
Copy link
Collaborator

laramiel commented Nov 25, 2024

tensorstore generates the CMake files from the bazel files using the bazel_to_cmake tool, and additionally the storage.pb.h file is generated by the protoc compiler.

To investigate more look in the generated build_rules.cmake file under the _deps/googleapis-* folders; it may be that the pb.h is somehow incorrectly referenced in this nested cmake configuration.

Edit: Issue content changed; it seems the issue/fix is not included in the latest "released" protobuf.
The fix is in: protocolbuffers/protobuf@8cc5f6b

If you want to try to update protobuf version that may be a challenge, as they tend to change a bunch of stuff and we patch the build files.

You could try to add a .bazelrc line with a per-file copt which disables that warning, perhaps?

Also, a pure bazel build on your machine might be helpful for future debugging; windows isn't our native development environment so we have to create the a custom environment for any exceptions which deviate from our CI environment.

@toloudis
Copy link
Author

my bad, I was changing the issue to something else entirely after redoing several builds on my latest branch... still not building correctly.
I will also investigate the other bad build with the pb.h as you suggested but the current issue is "newer"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants