Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Tokio v0.3 #318

Closed
Urhengulas opened this issue Oct 15, 2020 · 10 comments · Fixed by #319
Closed

Upgrade to Tokio v0.3 #318

Urhengulas opened this issue Oct 15, 2020 · 10 comments · Fixed by #319

Comments

@Urhengulas
Copy link
Contributor

Tokio v0.3 just released. Would be nice to upgrade 🙂

@tikue
Copy link
Collaborator

tikue commented Oct 15, 2020

Thanks for the heads up! I'll try to do it in the next few weeks. I'm kind of maintaining two branches right now, which might slow down this upgrade, depending on how much is involved.

@Urhengulas
Copy link
Contributor Author

@tikue I am happy to support a bit here. Should I have a look onto the master branch?

@tikue
Copy link
Collaborator

tikue commented Oct 16, 2020

You're more than welcome to have a go at it :)

Edit: the master branch is still the main branch as I haven't migrated to main yet. If you're interested in porting the tokio upgrade to my experimental branch, it's https://github.com/tikue/tarpc/tree/gats

@Urhengulas
Copy link
Contributor Author

Urhengulas commented Oct 17, 2020

@tikue I think I got most of the required changes on master.
You can have a look here: Urhengulas#1

@tikue
Copy link
Collaborator

tikue commented Oct 17, 2020

@Urhengulas looks great! I eagerly await your PR ☺️

@Urhengulas
Copy link
Contributor Author

@Urhengulas looks great! I eagerly await your PR ☺️

Still need to adapt some tests, but else we should be good 😉

@Urhengulas
Copy link
Contributor Author

Edit: If you're interested in porting the tokio upgrade to my experimental branch, it's https://github.com/tikue/tarpc/tree/gats

@tikue I will just try to cherry-pick it over. Probably there isn't much more to do there.

@Urhengulas
Copy link
Contributor Author

@tikue Would it be possible that you publish a 0.22.1 version with tokio 0.3?

@tikue
Copy link
Collaborator

tikue commented Oct 19, 2020

Done! Since it's a breaking change, it needed to be 0.23.

@Urhengulas
Copy link
Contributor Author

Done! Since it's a breaking change, it needed to be 0.23.

Thanks a lot :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants